diff options
author | Jonas Paulsson <paulsson@linux.vnet.ibm.com> | 2018-05-24 08:38:06 +0000 |
---|---|---|
committer | Jonas Paulsson <paulsson@linux.vnet.ibm.com> | 2018-05-24 08:38:06 +0000 |
commit | 4a65e92703d976447286e5b1f4c82984167dc857 (patch) | |
tree | 416018d2a2bc14a98dca59161aa7d23849802370 | |
parent | 3c819aac8ce83f5fe59ead4d0fa4c1340aa2b226 (diff) |
[ScheduleDAGInstrs / buildSchedGraph] Clear subregister entries also.
In addPhysRegDeps, subregister entries of the defined register were previously
not removed from Uses or Defs, which resulted in extra redundant edges for
subregs around the register definition.
This is principally NFC (in very rare cases some node got a different height).
This makes the DAG more readable and efficient in some cases.
Review: Andy Trick
https://reviews.llvm.org/D46838
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@333165 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/CodeGen/ScheduleDAGInstrs.cpp | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/lib/CodeGen/ScheduleDAGInstrs.cpp b/lib/CodeGen/ScheduleDAGInstrs.cpp index 32c0181a479..d1c5ddabb97 100644 --- a/lib/CodeGen/ScheduleDAGInstrs.cpp +++ b/lib/CodeGen/ScheduleDAGInstrs.cpp @@ -318,13 +318,14 @@ void ScheduleDAGInstrs::addPhysRegDeps(SUnit *SU, unsigned OperIdx) { } else { addPhysRegDataDeps(SU, OperIdx); - // clear this register's use list - if (Uses.contains(Reg)) - Uses.eraseAll(Reg); - - if (!MO.isDead()) { - Defs.eraseAll(Reg); - } else if (SU->isCall) { + // Clear previous uses and defs of this register and its subergisters. + for (MCSubRegIterator SubReg(Reg, TRI, true); SubReg.isValid(); ++SubReg) { + if (Uses.contains(*SubReg)) + Uses.eraseAll(*SubReg); + if (!MO.isDead()) + Defs.eraseAll(*SubReg); + } + if (MO.isDead() && SU->isCall) { // Calls will not be reordered because of chain dependencies (see // below). Since call operands are dead, calls may continue to be added // to the DefList making dependence checking quadratic in the size of |